Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N6 polish] Capitalize Expensify Card in the banner #5444

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Sep 23, 2021

Details

Small copy change. Change Expensify card to Expensify Card.

Fixed Issues

$ #5411

Tests

Go to the workspace and make sure the copy on the banner looks like this:
image

QA Steps

Same as Tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from a team September 23, 2021 12:40
@mountiny mountiny self-assigned this Sep 23, 2021
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team September 23, 2021 12:40
@mountiny mountiny changed the title Capitalize Expensify Card in the banner [N6 polish] Capitalize Expensify Card in the banner Sep 23, 2021
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit 16d8599 into main Sep 23, 2021
@chiragsalian chiragsalian deleted the vit-n6polishCardCopy branch September 23, 2021 19:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.1-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants